Fix for scheduling recurrent functions while inside scheduled function #6307
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just food for thought, after concerning myself with #6212. Is there really any power-saving on the ESP8266 by leaving "cont", like delay() does with the timer and yielding to sys? I was under the impression that all the power-saving modes come with some limition, such that the user sketch must decide what it wants to do. On the other hand, leaving "cont" like in delay() with a 1 millisecond resolution, but using microsecond times in Schedule.h, is that sensible? I see between 20-30µs cycle times in loop in tests of my coop scheduler, which doesn't block the whole user context for delays in separate tasks. If so, maybe the recurrent scheduling loop could check for the delay until the next timed function and "sleep"? |
dok-net
force-pushed
the
nested_scheduling
branch
from
8458447 to
b77f4d6
Compare
dok-net
added a commit
to dok-net/CoopTask
that referenced
this pull request
Jul 23, 2019
dok-net
force-pushed
the
nested_scheduling
branch
2 times, most recently
from
675cbf8 to
941f76f
Compare
dok-net
force-pushed
the
nested_scheduling
branch
2 times, most recently
from
fc89de3 to
071af4d
Compare
dok-net
force-pushed
the
nested_scheduling
branch
2 times, most recently
from
1476398 to
15c4eff
Compare
dok-net
force-pushed
the
nested_scheduling
branch
2 times, most recently
from
e601225 to
6dade19
Compare
dok-net
force-pushed
the
nested_scheduling
branch
from
6dade19 to
8d26aea
Compare
|
Superseded by #6485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @d-a-v,
I hope to have come up with a relatively small fix to Schedule that allows scheduling from inside already scheduled functions. I am using this with my CoopTask scheduling, without this patch, the sketch crashed, with it, it performs correctly. I don't see any reason for side-effects, like poorer performance. Memory use is minimally increased by the use of a recurrent_fn_t instance for rFirst instead of the previous pointer, but the logic looked cleaner to me when I began the patch, and I'd rather not change it back if there's no compelling reason.
Could you please review this?